Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try windows test workflow #440

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Try windows test workflow #440

merged 7 commits into from
Dec 5, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Dec 4, 2024 •
edited
Loading

Now that we don't depend on healpy, everything should run well on Windows. This adds a test to confirm that.

Modifies tests to not be posix-specific, and removes now-dead pixel_catalog_files method.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Before [081961a] After [7644cfc] Ratio Benchmark (Parameter)
13.6±0.7ms 13.9±0.3ms 1.02 benchmarks.Suite.time_inner_pixel_alignment
385±4ms 392±3ms 1.02 benchmarks.Suite.time_outer_pixel_alignment
1.02±0.03ms 1.03±0.02ms 1.01 benchmarks.time_test_cone_filter_multiple_order
95.8±0.4ms 95.4±1ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
46.9±0.7ms 46.9±0.9ms 1 benchmarks.Suite.time_pixel_tree_creation
125±0.5ms 126±1ms 1 benchmarks.time_test_alignment_even_sky
96.1±0.8ms 94.9±0.8ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
23.9±0.2ms 23.3±0.2ms 0.97 benchmarks.MetadataSuite.time_load_partition_info_order6

Click here to view all benchmarks.

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.26%. Comparing base (081961a) to head (711a171).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   93.29%   93.26%   -0.04%     
==========================================
  Files          47       47              
  Lines        2044     2034      -10     
==========================================
- Hits         1907     1897      -10     
  Misses        137      137

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

smcguire-cmu
smcguire-cmu approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@delucchi-cmu delucchi-cmu merged commit cca790d into main Dec 5, 2024
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/windows branch December 5, 2024 22:12
This was referenced Dec 6, 2024
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcguire-cmu smcguire-cmu smcguire-cmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucchi-cmu @smcguire-cmu